spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tianyi <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2817] [SQL] add "show create table" sup...
Date Fri, 08 Aug 2014 10:00:34 GMT
Github user tianyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1760#discussion_r15985611
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala ---
    @@ -95,7 +101,9 @@ class TestHiveContext(sc: SparkContext) extends HiveContext(sc) {
        * Replaces relative paths to the parent directory "../" with hiveDevHome since this
is how the
        * hive test cases assume the system is set up.
        */
    -  private def rewritePaths(cmd: String): String =
    +  private def rewritePaths(cmd: String): String = {
    +    // For some hive test case which contain ${system:test.tmp.dir}
    +    System.setProperty("test.tmp.dir", testTmpDir.getCanonicalPath)
    --- End diff --
    
    @chenghao-intel 
    I think we do not have to delete the temporal folder because we already delete created
table after unit test. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message