spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: Clean up and simplify Spark configuration
Date Fri, 08 Aug 2014 02:34:47 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/299#discussion_r15976048
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -64,9 +64,10 @@ private[spark] class Executor(
       // to what Yarn on this system said was available. This will be used later when SparkEnv
       // created.
       if (java.lang.Boolean.valueOf(
    -      System.getProperty("SPARK_YARN_MODE", System.getenv("SPARK_YARN_MODE"))))
    -  {
    +      System.getProperty("SPARK_YARN_MODE", System.getenv("SPARK_YARN_MODE")))) {
         conf.set("spark.local.dir", getYarnLocalDirs())
    +  } else if (sys.env.contains("SPARK_LOCAL_DIRS")) {
    +    conf.set("spark.local.dir", sys.env("SPARK_LOCAL_DIRS"))
    --- End diff --
    
    Maybe the problem here lies with spark-ec2's default configuration setting SPARK_LOCAL_DIRS
on the master when it should only really be used on workers, and in not setting `spark.local.dir`.
    
    I think the current documentation for SPARK_LOCAL_DIRS sort of suggests that it acts as
an override, without any caveats about whether it only should be used on workers, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message