spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikerlandson <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1021] Defer the data-driven computation...
Date Thu, 07 Aug 2014 12:12:59 GMT
Github user erikerlandson commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1689#discussion_r15931609
  
    --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
    @@ -113,8 +113,12 @@ class RangePartitioner[K : Ordering : ClassTag, V](
       private var ordering = implicitly[Ordering[K]]
     
       // An array of upper bounds for the first (partitions - 1) partitions
    -  private var rangeBounds: Array[K] = {
    -    if (partitions <= 1) {
    +  @volatile private var valRB: Array[K] = null
    --- End diff --
    
    My understanding of getPartitions was that it executes once, and is therefore "allowed
to be expensive".  Also, isn't rangeBounds generally only returning a reference to the array?
 (except for the first time, where it's computed)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message