spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From avulanov <...@git.apache.org>
Subject [GitHub] spark pull request: [MLLIB] [WIP] SPARK-1473: Feature selection fo...
Date Thu, 07 Aug 2014 07:50:12 GMT
Github user avulanov commented on the pull request:

    https://github.com/apache/spark/pull/1484#issuecomment-51441325
  
    @mengxr 
    1)  Looks good, probably I should implement `LabeledPointTransformer` same as `VectorTransformer`
and then implement `ChiSquared` that returns `ChiSquaredModel` after calling fit. The latter
with extend both transformers. One thing only - I need to use a different method name for
transform in `LabeledTransformer`.
    2)3)  Ok! 
    4)   I will test discretization in a few days as well. I need it for the project I am
working on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message