spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] [SPARK-2655] Change logging level from I...
Date Thu, 07 Aug 2014 06:17:36 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1776#discussion_r15919929
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala ---
    @@ -38,14 +38,14 @@ class BlockManagerMaster(var driverActor: ActorRef, conf: SparkConf)
extends Log
       /** Remove a dead executor from the driver actor. This is only called on the driver
side. */
       def removeExecutor(execId: String) {
         tell(RemoveExecutor(execId))
    -    logInfo("Removed " + execId + " successfully in removeExecutor")
    +    logDebug("Removed " + execId + " successfully in removeExecutor")
       }
     
       /** Register the BlockManager's id with the driver. */
       def registerBlockManager(blockManagerId: BlockManagerId, maxMemSize: Long, slaveActor:
ActorRef) {
    -    logInfo("Trying to register BlockManager")
    +    logDebug("Trying to register BlockManager")
    --- End diff --
    
    i'd leave this as info


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message