spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2848] Shade Guava in uber-jars.
Date Wed, 06 Aug 2014 22:33:49 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1813#discussion_r15908355
  
    --- Diff: pom.xml ---
    @@ -249,6 +249,7 @@
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
             <version>14.0.1</version>
    +        <scope>provided</scope>
    --- End diff --
    
    Yeah I understand what the scopes mean. But Spark is already "provided" to any project
compiling against Spark; you're not suppose to pull in Spark as compile-scope. This makes
all its transitive dependencies provided in this scenario already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message