spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2380: Support displaying accumulator val...
Date Mon, 04 Aug 2014 17:46:15 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1309#discussion_r15769145
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
    @@ -42,6 +44,13 @@ class TaskInfo(
       var gettingResultTime: Long = 0
     
       /**
    +   * Intermediate updates to accumulables during this task. Note that it is valid for
the same
    +   * accumulable to be updated multiple times in a single task or for two accumulables
with the
    +   * same name but different ID's to exist in a task.
    --- End diff --
    
    super nit: no apostrophe in IDs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message