spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2678][Core] Added "--" to prevent spark...
Date Sat, 02 Aug 2014 18:55:23 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1715#discussion_r15730624
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -377,8 +409,13 @@ private[spark] class SparkSubmitArguments(args: Seq[String]) {
             |
             |  --executor-memory MEM       Memory per executor (e.g. 1000M, 2G) (Default:
1G).
             |
    -        |  --help, -h                  Show this help message and exit
    -        |  --verbose, -v               Print additional debug output
    +        |  --help, -h                  Show this help message and exit.
    +        |  --verbose, -v               Print additional debug output.
    +        |
    +        |  --primary                   The primary jar file or Python file of the application.
    --- End diff --
    
    Thanks, will reword the option description.
    
    Updated the PR description to explain why `--primary` is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message