spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <>
Subject [GitHub] spark pull request: SPARK-2792. Fix reading too much or too little...
Date Fri, 01 Aug 2014 22:48:45 GMT
Github user mateiz commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
    @@ -389,27 +404,51 @@ class ExternalAppendOnlyMap[K, V, C](
        * An iterator that returns (K, C) pairs in sorted order from an on-disk map
       private class DiskMapIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])
    -    extends Iterator[(K, C)] {
    -    private val fileStream = new FileInputStream(file)
    -    private val bufferedStream = new BufferedInputStream(fileStream, fileBufferSize)
    +    extends Iterator[(K, C)]
    +  {
    --- End diff --
    Here I also removed some of the more paranoid asserts about batchSizes

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message