spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL][SPARK-2212]Hash Outer Join
Date Fri, 01 Aug 2014 00:53:08 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1147#discussion_r15678572
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
    @@ -37,6 +37,135 @@ case object BuildLeft extends BuildSide
     @DeveloperApi
     case object BuildRight extends BuildSide
     
    +/**
    + * Constant Value for Binary Join Node
    + */
    +object BinaryJoinNode {
    +  val SINGLE_NULL_LIST = Seq[Row](null)
    +  val EMPTY_NULL_LIST  = Seq[Row]()
    --- End diff --
    
    You can just do `Seq.empty[Row]` in the cases where you use this variable.  Due to erasure
no extra object needs to be allocated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message