spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SQL][SPARK-2212]Hash Outer Join
Date Fri, 01 Aug 2014 00:19:05 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1147#discussion_r15677845
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
    @@ -37,6 +37,135 @@ case object BuildLeft extends BuildSide
     @DeveloperApi
     case object BuildRight extends BuildSide
     
    +/**
    + * Constant Value for Binary Join Node
    + */
    +object BinaryJoinNode {
    +  val SINGLE_NULL_LIST = Seq[Row](null)
    +  val EMPTY_NULL_LIST  = Seq[Row]()
    +}
    +
    +// TODO If join key was null should be considered as equal? In Hive this is configurable.
    +
    +/**
    + * Output the tuples for the matched (with the same join key) join group, base on the
join types,
    + * Both input iterators should be repeatable.
    + */
    +trait BinaryRepeatableIteratorNode extends BinaryNode {
    +  self: Product =>
    +
    +  val leftNullRow = new GenericRow(left.output.length)
    +  val rightNullRow = new GenericRow(right.output.length)
    +
    +  val joinedRow = new JoinedRow()
    +
    +  val boundCondition = InterpretedPredicate(
    +    condition
    +      .map(c => BindReferences.bindReference(c, left.output ++ right.output))
    +      .getOrElse(Literal(true)))
    +
    +  def condition: Option[Expression]
    +  def joinType: JoinType
    +
    +  // TODO we need to rewrite all of the iterators with our own implementation instead
of the scala
    +  // iterator for performance / memory usage reason. 
    +
    +  def leftOuterIterator(key: Row, leftIter: Iterable[Row], rightIter: Iterable[Row])
    +  : Iterator[Row] = {
    --- End diff --
    
    We don't usually orphan the return type on its own line.  Instead I'd wrap the arguments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message