Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: mateiz <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-1460-spark@git.apache.org>
In-Reply-To: <git-pr-1460-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-2538] [PySpark] Hash based disk
 spillin...
Content-Type: text/plain
Message-Id: <20140722022716.6B9449AE533@tyr.zones.apache.org>
Date: Tue, 22 Jul 2014 02:27:16 +0000 (UTC)

Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1460#discussion_r15208070
  
    --- Diff: python/pyspark/shuffle.py ---
    @@ -0,0 +1,258 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +import os
    +import sys
    +import platform
    +import shutil
    +import warnings
    +
    +from pyspark.serializers import BatchedSerializer, AutoSerializer
    +
    +try:
    +    import psutil
    +
    +    def get_used_memory():
    +        self = psutil.Process(os.getpid())
    +        return self.memory_info().rss >> 20
    +
    +except ImportError:
    +
    +    def get_used_memory():
    +        if platform.system() == 'Linux':
    +            for line in open('/proc/self/status'):
    +                if line.startswith('VmRSS:'):
    +                    return int(line.split()[1]) >> 10
    +        else:
    +            warnings.warn("please install psutil to get accurate memory usage")
    +            if platform.system() == "Darwin":
    +                import resource
    +                return resource.getrusage(resource.RUSAGE_SELF).ru_maxrss >> 20
    +            # TODO: support windows
    +        return 0
    +
    +
    +class Merger(object):
    +    """
    +    merge shuffled data together by combinator
    +    """
    +
    +    def merge(self, iterator):
    +        raise NotImplementedError
    +
    +    def iteritems(self):
    +        raise NotImplementedError
    +
    +
    +class MapMerger(Merger):
    +    """
    +    In memory merger based on map
    +    """
    +
    +    def __init__(self, combiner):
    +        self.combiner = combiner
    +        self.data = {}
    +
    +    def merge(self, iterator):
    +        d, comb = self.data, self.combiner
    +        for k, v in iter(iterator):
    +            d[k] = comb(d[k], v) if k in d else v
    +
    +    def iteritems(self):
    +        return self.data.iteritems()
    +
    +
    +class ExternalHashMapMerger(Merger):
    +
    +    """
    +    External merger will dump the aggregated data into disks when memory usage
    +    is above the limit, then merge them together.
    +
    --- End diff --
    
    Add a high-level description here about how the class works and what the main variables and methods are. For example take a look at the class comment in https://github.com/apache/spark/pull/1499/files#diff-7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---