Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F05BE11AA0 for ; Mon, 14 Jul 2014 17:08:16 +0000 (UTC) Received: (qmail 65230 invoked by uid 500); 14 Jul 2014 17:08:16 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 65208 invoked by uid 500); 14 Jul 2014 17:08:16 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@spark.apache.org Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 65197 invoked by uid 99); 14 Jul 2014 17:08:16 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jul 2014 17:08:16 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 4C531931222; Mon, 14 Jul 2014 17:08:16 +0000 (UTC) From: mengxr To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-2471] remove runtime scope for jets3t Content-Type: text/plain Message-Id: <20140714170816.4C531931222@tyr.zones.apache.org> Date: Mon, 14 Jul 2014 17:08:16 +0000 (UTC) Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1402#issuecomment-48927532 @ScrapCodes I agree with @srowen that the assembly jar should include runtime libraries except those marked "provided". If we cannot find a way to let sbt understand maven runtime scope, we should merge this change because without jets3t all S3 operations are broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---