spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] [SPARK-2764] Simplify daemon.py process ...
Date Thu, 31 Jul 2014 06:52:05 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1680#discussion_r15628219
  
    --- Diff: python/pyspark/daemon.py ---
    @@ -176,13 +120,30 @@ def handle_sigchld(*args):
         try:
             while not should_exit():
                 try:
    -                # Spark tells us to exit by closing stdin
    -                if os.read(0, 512) == '':
    -                    shutdown()
    -            except EnvironmentError as err:
    -                if err.errno != EINTR:
    -                    shutdown()
    +                ready_fds = select.select([0, listen_sock], [], [])[0]
    --- End diff --
    
    select() should have an timeout here, so after SIGTERM, it will not exit until events
happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message