spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2045 Sort-based shuffle
Date Thu, 31 Jul 2014 01:02:50 GMT
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/1499#issuecomment-50701304
  
    I took another pass over the patch and the changes look ready to me. I also tested this
locally and verified that the shuffle files were actually cleaned up. There is still a lot
of very similar code in the ExternalSorter and the EAOM, though this is not of 1.1 priority
to resolve. Instead, I have filed a [JIRA](https://issues.apache.org/jira/browse/SPARK-2761)
for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message