spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2646. log4j initialization not quite com...
Date Wed, 30 Jul 2014 18:59:03 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1547#discussion_r15604577
  
    --- Diff: core/src/main/scala/org/apache/spark/Logging.scala ---
    @@ -110,23 +110,26 @@ trait Logging {
       }
     
       private def initializeLogging() {
    -    // If Log4j is being used, but is not initialized, load a default properties file
    -    val binder = StaticLoggerBinder.getSingleton
    -    val usingLog4j = binder.getLoggerFactoryClassStr.endsWith("Log4jLoggerFactory")
    -    val log4jInitialized = LogManager.getRootLogger.getAllAppenders.hasMoreElements
    -    if (!log4jInitialized && usingLog4j) {
    +    // If Log4j 1.2 is being used, but is not initialized, load a default properties
file
    +    val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
    +    // This minimally distinguishes the log4j 1.2 binding, currently
    +    // org.slf4j.impl.Log4jLoggerFactory, from the log4j 2.0 binding, currently
    +    // org.apache.logging.slf4j.Log4jLoggerFactory
    +    val usingLog4j12 =
    +      binderClass.endsWith("Log4jLoggerFactory") && binderClass.startsWith("org.slf4j.")
    +    val log4j12Initialized = LogManager.getRootLogger.getAllAppenders.hasMoreElements
    +    if (!log4j12Initialized && usingLog4j12) {
           val defaultLogProps = "org/apache/spark/log4j-defaults.properties"
           Option(Utils.getSparkClassLoader.getResource(defaultLogProps)) match {
             case Some(url) =>
               PropertyConfigurator.configure(url)
    -          log.info(s"Using Spark's default log4j profile: $defaultLogProps")
    --- End diff --
    
    On second thought, I got more paranoid the more I reasoned about it. There would still
be a reentrant call through a synchronized block depending on state of the initialized flag...
just didn't seem worth it. I made it a System.out message and added a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message