spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2632, SPARK-2576. Fixed by only importin...
Date Wed, 30 Jul 2014 07:18:33 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1635#discussion_r15569238
  
    --- Diff: repl/src/test/scala/org/apache/spark/repl/ReplSuite.scala ---
    @@ -256,6 +256,33 @@ class ReplSuite extends FunSuite {
         assertDoesNotContain("error:", output)
         assertDoesNotContain("Exception", output)
       }
    +
    +  test("SPARK-2576 importing SQLContext.createSchemaRDD.") {
    +    // We need to use local-cluster to test this case.
    +    val output = runInterpreter("local-cluster[1,1,512]",
    +      """
    +        |val sqlContext = new org.apache.spark.sql.SQLContext(sc)
    +        |import sqlContext.createSchemaRDD
    +        |case class TestCaseClass(value: Int)
    +        |sc.parallelize(1 to 10).map(x => TestCaseClass(x)).collect
    --- End diff --
    
    Can we call `toSchemaRDD` here before the `collect()` to make sure the implicit is triggered?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message