spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From naftaliharris <...@git.apache.org>
Subject [GitHub] spark pull request: Check if margin > 0, not if prob > 0.5
Date Tue, 29 Jul 2014 18:44:59 GMT
Github user naftaliharris commented on the pull request:

    https://github.com/apache/spark/pull/1057#issuecomment-50520177
  
    Yeah, that fixes the overflow errors! The second probability calculation has some slight
numerical issues, (see in-line comment), but not a huge deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message