spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2099. Report progress while task is runn...
Date Tue, 29 Jul 2014 04:56:20 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15506045
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -348,4 +353,48 @@ private[spark] class Executor(
           }
         }
       }
    +
    +  def stop() {
    +    isStopped = true
    +    threadPool.shutdown()
    --- End diff --
    
    should this be `shutdownNow`? My concern is that in some cases people set the akka timeout
to many seconds. If the driver has stopped its responding actor, this could hang for a long
time. Since this thread pool is only performing best-effort statuts updates, it seems like
doing a hard shutdown might be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message