spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2179][SQL] Public API for DataTypes and...
Date Mon, 28 Jul 2014 18:34:12 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1346#discussion_r15481080
  
    --- Diff: python/pyspark/sql.py ---
    @@ -20,8 +20,413 @@
     
     from py4j.protocol import Py4JError
     
    -__all__ = ["SQLContext", "HiveContext", "LocalHiveContext", "TestHiveContext", "SchemaRDD",
"Row"]
    +__all__ = [
    +    "StringType", "BinaryType", "BooleanType", "DecimalType", "DoubleType",
    +    "FloatType", "ByteType", "IntegerType", "LongType", "ShortType",
    +    "ArrayType", "MapType", "StructField", "StructType",
    +    "SQLContext", "HiveContext", "LocalHiveContext", "TestHiveContext", "SchemaRDD",
"Row"]
     
    +class PrimitiveTypeSingleton(type):
    +    _instances = {}
    +    def __call__(cls):
    +        if cls not in cls._instances:
    +            cls._instances[cls] = super(PrimitiveTypeSingleton, cls).__call__()
    +        return cls._instances[cls]
    +
    +class StringType(object):
    +    """Spark SQL StringType
    +
    +    The data type representing string values.
    +
    +    """
    +    __metaclass__ = PrimitiveTypeSingleton
    +
    +    def _get_scala_type_string(self):
    +        return "StringType"
    +
    +class BinaryType(object):
    +    """Spark SQL BinaryType
    +
    +    The data type representing bytes values and bytearray values.
    --- End diff --
    
    We probably just want to say byte arrays here since we have a separate type for byte.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message