spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2082] stratified sampling in PairRDDFun...
Date Sun, 27 Jul 2014 23:48:35 GMT
Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/1025#issuecomment-50290028
  
    @dorx I removed commons-math3 from dependencies, separated `sampleByKey` and `sampleByKeyExact`,
and corrected the math in waitlisting in sampling with replacement.
    
    Other than those changes, the refactoring was completely based on your implementation.
I did some renaming but I'm not taking any credit for the implementation. Some of the refactoring
was unnecessary, which was partially because I did this around 5am and my head was not clear.
I'm really sorry for the unnecessary code changes.
    
    Since this is apparently your contribution, do you mind re-opening the PR? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message