spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2523] [SQL] [WIP] Hadoop table scan bug...
Date Sun, 27 Jul 2014 11:49:38 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1439#discussion_r15438771
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTableScanSuite.scala
---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.hive.execution
    +
    +import org.apache.spark.{SparkConf, SparkContext}
    +import org.apache.spark.sql.hive.test.TestHive
    +import org.scalatest.{BeforeAndAfterAll, FunSuite}
    +
    +class HiveTableScanSuite extends HiveComparisonTest {
    +  // MINOR HACK: You must run a query before calling reset the first time.
    +  TestHive.hql("SHOW TABLES")
    +  TestHive.reset()
    +
    +  TestHive.hql("""CREATE TABLE part_scan_test (key STRING, value STRING) PARTITIONED
BY (ds STRING) 
    +                 | ROW FORMAT SERDE 
    +                 | 'org.apache.hadoop.hive.serde2.columnar.LazyBinaryColumnarSerDe' 
    +                 | STORED AS RCFILE
    +               """.stripMargin)
    +  TestHive.hql("""from src 
    +                 | insert into table part_scan_test PARTITION (ds='2010-01-01') 
    +                 | select 100,100 limit 1
    +               """.stripMargin)
    +  TestHive.hql("""ALTER TABLE part_scan_test set SERDE 
    +                 | 'org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe'
    +               """.stripMargin)
    +  TestHive.hql("""from src insert into table part_scan_test PARTITION (ds='2010-01-02')

    +                 | select 200,200 limit 1
    +               """.stripMargin)
    --- End diff --
    
    nit: let's make all SQL keywords capital here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message