spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2514] [mllib] Random RDD generator
Date Fri, 25 Jul 2014 07:54:18 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1520#discussion_r15389645
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/rdd/RandomRDD.scala ---
    @@ -0,0 +1,118 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.mllib.rdd
    +
    +import org.apache.spark.{Partition, SparkContext, TaskContext}
    +import org.apache.spark.mllib.linalg.{DenseVector, Vector}
    +import org.apache.spark.mllib.random.DistributionGenerator
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.util.Utils
    +
    +import scala.util.Random
    +
    +private[mllib] class RandomRDDPartition(override val index: Int,
    +    val size: Int,
    +    val generator: DistributionGenerator,
    +    val seed: Long) extends Partition {
    +  // Safety check in case a Long > Int.MaxValue cast to an Int was passed in as size
    +  require(size > 0, "Positive partition size required.")
    +}
    +
    +// These two classes are necessary since Range objects in Scala cannot have size >
Int.MaxValue
    +private[mllib] class RandomRDD(@transient private var sc: SparkContext,
    +    size: Long,
    +    numSlices: Int,
    --- End diff --
    
    `numSlices` -> `numPartitions` to match the naming in previous code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message