spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbtsai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2479][MLlib] Comparing floating-point n...
Date Thu, 24 Jul 2014 19:19:47 GMT
Github user dbtsai commented on the pull request:

    https://github.com/apache/spark/pull/1425#issuecomment-50064963
  
    @mengxr `%+-` is used as an operator to indicate this is relative error. Users can write
`assert(a ~== b %+- 1E-10)` for relative error, and `assert(a ~== b +- 1E-10)` for absolute
error. 
    
    As a result, the syntactic sugar would be the same as scalatest for absolute error except
they use `===` instead of `~==`. 
    
    On the other hand, however, using `absErr`/`relErr` seems to be easier to remember. I'm
open to both, and it's easy to change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message