spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harishreedharan <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2582. Make Block Manager Master pluggabl...
Date Tue, 22 Jul 2014 20:00:26 GMT
Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1506#discussion_r15252048
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
    @@ -215,9 +215,15 @@ object SparkEnv extends Logging {
           "MapOutputTracker",
           new MapOutputTrackerMasterActor(mapOutputTracker.asInstanceOf[MapOutputTrackerMaster],
conf))
     
    -    val blockManagerMaster = new BlockManagerMaster(registerOrLookup(
    -      "BlockManagerMaster",
    -      new BlockManagerMasterActor(isLocal, conf, listenerBus)), conf)
    +    val blockManagerMasterType = conf.get("spark.blockmanager.type", "standalone")
    +    var blockManagerMaster: BlockManagerMaster = null
    +    blockManagerMasterType match {
    +      case _ =>
    +        // Since currently only one option exists, this is what is to be done in any
case.
    +        blockManagerMaster = new StandaloneBlockManagerMaster(registerOrLookup(
    --- End diff --
    
    I thought about doing that - but doing that does not allow us a way to force the implementation
to use the Akka BlockManagerMasterActor, since the Block Managers would continue to use that.
If we could somehow force that - then it would be a good idea to just use FQCN.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message