spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2565. Update ShuffleReadMetrics as block...
Date Tue, 22 Jul 2014 19:34:42 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1507#discussion_r15250466
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala ---
    @@ -73,11 +75,16 @@ class TaskMetrics extends Serializable {
       var inputMetrics: Option[InputMetrics] = None
     
       /**
    -   * If this task reads from shuffle output, metrics on getting shuffle data will be
collected here
    +   * If this task reads from shuffle output, metrics on getting shuffle data will be
collected here.
    +   * This includes read metrics aggregated over all the task's shuffle dependencies.
        */
    -  private var _shuffleReadMetrics: Option[ShuffleReadMetrics] = None
    +  var shuffleReadMetrics: Option[ShuffleReadMetrics] = None
    --- End diff --
    
    Can we make this and depsShuffleReadMetrics private again, since they should only be updated
through createShuffleReadMetricsForDependency() and mergeShuffleReadMetrics()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message