spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2099. Report progress while task is runn...
Date Mon, 21 Jul 2014 23:36:08 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1056#discussion_r15203692
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
    @@ -230,6 +229,10 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf,
listenerBus
         blockManagerIdByExecutor.get(execId).foreach(removeBlockManager)
       }
     
    +  /**
    +   * Returns true if everything works out, false if the driver does not know about the
given block
    +   * manager, which means the block manager should re-register.
    +   */
       private def heartBeat(blockManagerId: BlockManagerId): Boolean = {
    --- End diff --
    
    Can we rename this `heartbeatReceived`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message