spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgravescs <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2555] Support configuration spark.sched...
Date Fri, 18 Jul 2014 14:04:00 GMT
Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/1462#issuecomment-49434048
  
    Did you test it on a cluster?  I unfortunately don't have access to one and am not an
expert on mesos.
    
    Is there a race condition between when the scheduler backend increments totalExpectedExecutors
and when we actually do the check to see if we have enough?  Meaning in this case we increment
it as they come in as resource offers, we start the executors, it registers, then we do the
check, so its possible once we get 1 in that totalExpectedExecutors =1 * minRegisteredRatio
(say 100) == executorActor.size() (1) even though we really expect say 10 to come in?
    
    I think the same thing actually applies in standalone mode too but I missed it in previous
pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message