spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-695] In DAGScheduler's getPreferredLocs...
Date Wed, 16 Jul 2014 18:32:47 GMT
Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1362#discussion_r15018046
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1107,7 +1106,6 @@ class DAGScheduler(
                 case shufDep: ShuffleDependency[_, _, _] =>
                   val mapStage = getShuffleMapStage(shufDep, stage.jobId)
                   if (!mapStage.isAvailable) {
    -                visitedStages += mapStage
    --- End diff --
    
    I'm curious, why did you remove this? It seems unrelated to the preferred locs fix, and
it was necessary to prevent exponential explosion here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message