spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2465. Use long as user / item ID for ALS
Date Tue, 15 Jul 2014 10:08:02 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1393#discussion_r14926032
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
    @@ -53,7 +53,7 @@ class MatrixFactorizationModel private[mllib] (
         * @param usersProducts  RDD of (user, product) pairs.
         * @return RDD of Ratings.
         */
    -  def predict(usersProducts: RDD[(Int, Int)]): RDD[Rating] = {
    +  def predict(usersProducts: RDD[(Long, Long)]): RDD[Rating] = {
    --- End diff --
    
    I had understood all of this to be an `@Experimental` API, though it is not consistently
marked. For example, `Rating` is experimental but its API is actually bound to this API here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message