spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1022] Kafka unit test that actually sen...
Date Fri, 11 Jul 2014 03:27:16 GMT
Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/557#issuecomment-48690832
  
    Its weird that zookeeper behavior is so unpredictable that this test would
    be so flaky. If we make the low-level API we should still keep the
    high-level API for backward compatibility for a while, so it would be good
    if a fix for this can be figured out.
    
    TD
    
    
    On Thu, Jul 10, 2014 at 6:07 PM, Saisai Shao <notifications@github.com>
    wrote:
    
    > Yes, I did revisit this patch again long ago, but as you mentioned it is
    > so flaky. I guess the main reason is that our Kafka API call is in high
    > level which involves Zookeeper's behavior (unknown latency or others), so
    > our unit test cannot precisely reproduce the result each time. I think if
    > we shift to some low level API, we can have more power to control the
    > behavior, this problem can be easily fixed.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/spark/pull/557#issuecomment-48683925>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message