spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From concretevitamin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2407: Added internal implementation of S...
Date Thu, 10 Jul 2014 18:12:59 GMT
Github user concretevitamin commented on the pull request:

    https://github.com/apache/spark/pull/1359#issuecomment-48642397
  
    Hey @willb - thanks for working on this, which is going to be very useful for Spark SQL.
I left a couple minor comments. Another general concern is the performance of `eval()`. If
there are ways to reduce branchings, or reduce the function call (not sure if @inline will
help), we should probably do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message