spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From willb <>
Subject [GitHub] spark pull request: SPARK-2407: Added internal implementation of S...
Date Thu, 10 Jul 2014 18:07:26 GMT
Github user willb commented on a diff in the pull request:
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -860,6 +860,7 @@ private[hive] object HiveQl {
       val BETWEEN = "(?i)BETWEEN".r
       val WHEN = "(?i)WHEN".r
       val CASE = "(?i)CASE".r
    +  val SUBSTR = "(?i)I_SUBSTR(?:ING)?".r
    --- End diff --
    Good catch -- the `I_` was spuriously committed.  (I had that in my working tree so that
I could easily compare Catalyst and Hive `substr` from the console.)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message