spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: Update SQLConf.scala
Date Thu, 03 Jul 2014 23:03:23 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1272#discussion_r14541981
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -64,20 +64,17 @@ trait SQLConf {
       }
     
       def get(key: String): String = {
    -    if (!settings.containsKey(key)) {
    -      throw new NoSuchElementException(key)
    -    }
    -    settings.get(key)
    +    Option(settings.get(key)).orElse(throw new NoSuchElementException(key))
    --- End diff --
    
    this line should be getOrElse


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message