Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@spark.apache.org
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-1103-spark@git.apache.org>
In-Reply-To: <git-pr-1103-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-2162] Double check in doGetLocal
 to avo...
Content-Type: text/plain
Message-Id: <20140618080653.D0B4F83B57B@tyr.zones.apache.org>
Date: Wed, 18 Jun 2014 08:06:53 +0000 (UTC)

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1103#discussion_r13903517
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ---
    @@ -363,6 +363,12 @@ private[spark] class BlockManager(
         val info = blockInfo.get(blockId).orNull
         if (info != null) {
           info.synchronized {
    +        // Double check to make sure the block is still there, since it
    +        // might has been removed when we actually come here.
    --- End diff --
    
    has -> have
    
    also can you point out in the comment that this only works because "removeBlock" also synchronizes on the block info object?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---