Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6497F113CC for ; Sat, 7 Jun 2014 06:21:53 +0000 (UTC) Received: (qmail 73204 invoked by uid 500); 7 Jun 2014 06:21:53 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 73181 invoked by uid 500); 7 Jun 2014 06:21:53 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@spark.apache.org Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 73171 invoked by uid 99); 7 Jun 2014 06:21:53 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jun 2014 06:21:53 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id E6AA88BB811; Sat, 7 Jun 2014 06:21:52 +0000 (UTC) From: rxin To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [Spark 2060][SQL] Querying JSON Datasets with ... Content-Type: text/plain Message-Id: <20140607062152.E6AA88BB811@tyr.zones.apache.org> Date: Sat, 7 Jun 2014 06:21:52 +0000 (UTC) Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/999#discussion_r13518257 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/package.scala --- @@ -17,8 +17,56 @@ package org.apache.spark.sql.catalyst +import org.apache.spark.sql.catalyst.expressions.Attribute +import org.apache.spark.sql.catalyst.types.{StructField, DataType, ArrayType, StructType} --- End diff -- order the imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---