spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2104] Fix task serializing issues when ...
Date Mon, 30 Jun 2014 01:30:20 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1245#discussion_r14333421
  
    --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
    @@ -96,15 +98,15 @@ class HashPartitioner(partitions: Int) extends Partitioner {
      * the value of `partitions`.
      */
     class RangePartitioner[K : Ordering : ClassTag, V](
    -    partitions: Int,
    +    var partitions: Int,
    --- End diff --
    
    Hi Reynold, thanks for your comments, will this field `partitions` be used in executor
side, I think this field can be transient according to my knowledge, am I miss something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message