spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-2297][UI] Make task attempt and specula...
Date Thu, 26 Jun 2014 21:22:05 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1236#discussion_r14267614
  
    --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala ---
    @@ -453,8 +454,8 @@ class JsonProtocolSuite extends FunSuite {
         new StageInfo(a, "greetings", b, rddInfos, "details")
       }
     
    -  private def makeTaskInfo(a: Long, b: Int, c: Long) = {
    -    new TaskInfo(a, b, c, "executor", "your kind sir", TaskLocality.NODE_LOCAL)
    +  private def makeTaskInfo(a: Long, b: Int, c: Int, d: Long, e: Boolean) = {
    --- End diff --
    
    can you name "e" isSpeculative?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message