spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [WIP] Loading spark-defaults.conf when creatin...
Date Thu, 26 Jun 2014 17:03:49 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1233#discussion_r14252580
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -383,20 +382,5 @@ private[spark] class SparkSubmitArguments(args: Seq[String]) {
     
     object SparkSubmitArguments {
       /** Load properties present in the given file. */
    -  def getPropertiesFromFile(file: File): Seq[(String, String)] = {
    -    require(file.exists(), s"Properties file $file does not exist")
    -    require(file.isFile(), s"Properties file $file is not a normal file")
    -    val inputStream = new FileInputStream(file)
    -    try {
    -      val properties = new Properties()
    -      properties.load(inputStream)
    -      properties.stringPropertyNames().toSeq.map(k => (k, properties(k).trim))
    -    } catch {
    -      case e: IOException =>
    -        val message = s"Failed when loading Spark properties file $file"
    -        throw new SparkException(message, e)
    -    } finally {
    -      inputStream.close()
    -    }
    -  }
    +  def getPropertiesFromFile(file: File) = Utils.getPropertiesFromFile(file)
    --- End diff --
    
    At this point, might as well remove the object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message