spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-2034. KafkaInputDStream doesn't close re...
Date Sun, 22 Jun 2014 06:48:47 GMT
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/980#discussion_r14053248
  
    --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaInputDStream.scala
---
    @@ -112,10 +114,14 @@ class KafkaReceiver[
         val topicMessageStreams = consumerConnector.createMessageStreams(
           topics, keyDecoder, valueDecoder)
     
    -
    -    // Start the messages handler for each partition
    -    topicMessageStreams.values.foreach { streams =>
    -      streams.foreach { stream => executorPool.submit(new MessageHandler(stream))
}
    +    val executorPool = Executors.newFixedThreadPool(topics.values.sum)
    --- End diff --
    
    I see that actually you didn't add this name, so nevermind!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message