spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mateiz <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1937: fix issue with task locality
Date Sat, 21 Jun 2014 23:25:33 GMT
Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r14052131
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
    @@ -77,6 +77,10 @@ class FakeTaskScheduler(sc: SparkContext, liveExecutors: (String, String)*
/* ex
       override def isExecutorAlive(execId: String): Boolean = executors.contains(execId)
     
       override def hasExecutorsAliveOnHost(host: String): Boolean = executors.values.exists(_
== host)
    +
    +  def addExecutor(newExecutors: (String, String)*) {
    --- End diff --
    
    Make this take just a single executor as a time, in order to match the name of the method.
And then you can just pass the host and executor ID as separate parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message