spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1478: Upgrade FlumeInputDStream's FlumeR...
Date Fri, 20 Jun 2014 20:49:46 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/566#discussion_r14040594
  
    --- Diff: external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeInputDStream.scala
---
    @@ -36,17 +36,27 @@ import org.apache.spark.streaming.StreamingContext
     import org.apache.spark.streaming.dstream._
     import org.apache.spark.Logging
     import org.apache.spark.streaming.receiver.Receiver
    +import org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory
    +import org.jboss.netty.channel.ChannelPipelineFactory
    +import java.util.concurrent.Executors
    +import org.jboss.netty.channel.Channels
    +import org.jboss.netty.handler.codec.compression.ZlibDecoder
    --- End diff --
    
    please dedup, and sort. see import style in https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message