spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harishreedharan <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1729. Make Flume pull data from source, ...
Date Mon, 16 Jun 2014 18:59:06 GMT
Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/807#discussion_r13823887
  
    --- Diff: external/flume/src/main/scala/org/apache/spark/streaming/flume/EventTransformer.scala
---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.streaming.flume
    +
    +import java.io.{ObjectOutput, ObjectInput}
    +
    +import scala.collection.JavaConversions._
    +
    +import org.apache.spark.util.Utils
    +import org.apache.spark.Logging
    +
    +/**
    + * A simple object that provides the implementation of readExternal and writeExternal
for both
    + * the wrapper classes for Flume-style Events.
    + */
    +object EventTransformer extends Logging {
    +  def readExternal(in: ObjectInput): (java.util.HashMap[CharSequence, CharSequence],
    +    Array[Byte]) = {
    +    val bodyLength = in.readInt()
    +    val bodyBuff = new Array[Byte](bodyLength)
    +    in.read(bodyBuff)
    +
    +    val numHeaders = in.readInt()
    +    val headers = new java.util.HashMap[CharSequence, CharSequence]
    +
    +    for (i <- 0 until numHeaders) {
    +      val keyLength = in.readInt()
    +      val keyBuff = new Array[Byte](keyLength)
    +      in.read(keyBuff)
    --- End diff --
    
    This is just currently existing code refactored to a new class. I'd rather not change
it unless absolutely required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message