spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ash211 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-983] Support external sorting
Date Mon, 16 Jun 2014 18:10:25 GMT
Github user ash211 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1090#discussion_r13820938
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/SortedParitionsRDD.scala ---
    @@ -0,0 +1,337 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rdd
    +
    +import scala.reflect.ClassTag
    +import scala.collection.mutable.ArrayBuffer
    +import java.io.{InputStream, BufferedInputStream, FileInputStream, File, Serializable,
EOFException}
    +import org.apache.spark.{Partition, TaskContext}
    +import org.apache.spark.{Logging, SparkEnv}
    +import org.apache.spark.serializer.Serializer
    +import org.apache.spark.storage.{BlockId, BlockManager}
    +import org.apache.spark.util.SizeEstimator
    +
    +/**
    + * An RDD that sorts each of it's partitions independently.
    + * 
    + * If partitions are too large to fit in memory, they are externally sorted.
    + * 
    + * Two parameters control the memory threshold for external sort:
    + *
    + *   `spark.shuffle.memoryFraction` specifies the collective amount of memory used for
storing
    + *   sub lists as a fraction of the executor's total memory. Since each concurrently
running
    + *   task maintains one map, the actual threshold for each map is this quantity divided
by the
    + *   number of running tasks.
    + *
    + *   `spark.shuffle.safetyFraction` specifies an additional margin of safety as a fraction
of
    + *   this threshold, in case sub list size estimation is not sufficiently accurate.
    + */
    +private[spark] class SortedPartitionsRDD[T: ClassTag](
    --- End diff --
    
    Typo in filename: SortedParitionsRDD.scala -> SortedPartitionsRDD.scala


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message