spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sryza <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1946] Submit stage after (configured nu...
Date Fri, 13 Jun 2014 07:32:52 GMT
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/900#discussion_r13740722
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
---
    @@ -48,6 +48,10 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, actorSystem:
A
       var totalCoreCount = new AtomicInteger(0)
       val conf = scheduler.sc.conf
       private val timeout = AkkaUtils.askTimeout(conf)
    +  val minRegisteredNum = conf.getDouble("spark.executor.minRegisteredNum", 0)
    --- End diff --
    
    +1 for using a percentage.   spark.scheduler seems like the right prefix (and we should
use it for maxRegisteredWaitingTime as well)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message