spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: [Minor] Fix style, formatting and naming in Bl...
Date Thu, 12 Jun 2014 00:58:18 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1058#discussion_r13683274
  
    --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
    @@ -98,7 +102,7 @@ private[spark] class CacheManager(blockManager: BlockManager) extends
Logging {
                       values.asInstanceOf[Iterator[T]]
                     case None =>
                       logInfo("Failure to store %s".format(key))
    -                  throw new Exception("Block manager failed to return persisted valued")
    --- End diff --
    
    Could I stick my nose in and suggest that while you are here, any more specific subclass
than Exception would be nice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message