spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1968][SQL] SQL/HiveQL command for cachi...
Date Wed, 11 Jun 2014 05:25:23 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1038#discussion_r13634316
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -218,6 +218,10 @@ private[hive] object HiveQl {
               case Array(key, value) => // "set key=value"
                 SetCommand(Some(key), Some(value))
             }
    +      } else if (sql.toLowerCase.startsWith("cache table")) {
    --- End diff --
    
    How about `sql.trim.toLowerCase.startsWith(...)` like above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message