spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lirui-intel <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-1937: fix issue with task locality
Date Tue, 10 Jun 2014 15:45:36 GMT
Github user lirui-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/892#discussion_r13601229
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -388,7 +386,7 @@ private[spark] class TaskSetManager(
           val curTime = clock.getTime()
     
           var allowedLocality = getAllowedLocalityLevel(curTime)
    -      if (allowedLocality > maxLocality) {
    +      if (allowedLocality > maxLocality && myLocalityLevels.contains(maxLocality))
{
             allowedLocality = maxLocality   // We're not allowed to search for farther-away
tasks
           }
    --- End diff --
    
    Hi @mridulm , another possible change: maxLocality always starts from PROCESS_LOCAL, how
about making it start from the highest level of myLocalityLevels? Do you think this makes
sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message