spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: Add timestamps to block manager events.
Date Mon, 09 Jun 2014 23:27:19 GMT
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/654#issuecomment-45557210
  
    Yeah, there are a few other events that could use a timestamp (SparkListenerEnvironmentUpdate,
SparkListenerUnpersistRDD).
    
    In any case, somewhat unrelated, but if those changes are desired, I'd suggest investigating
a more automatic way of creating the serialized events; manually handing the conversion to
and from JSON is tedious and error-prone. I'm not familiar with the json4s library, but I'm
thinking along the lines of Jackson's automatic reflection-based introspector + annotations
for dealing with backwards compatibility / missing properties / other issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message