spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pwendell <...@git.apache.org>
Subject [GitHub] spark pull request: Add unit test to spark_ec2 script
Date Mon, 09 Jun 2014 06:00:16 GMT
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/134#issuecomment-45463264
  
    Hey @rxin so I think the "no binaries" means "no compiled code" - I don't think it means
we can't have a zip file. These zip files only contain uncompiled `.py` files, so I think
it's okay.
    
    That said @logc I noticed the zip files are pretty large (e.g. almost one MB total). They
include a lot of docs/html/etc that aren't needed. Would you mind re-packaging them into smaller
zips (i.e. just remove the stuff in there that is not needed). I do like having it be self
contained.
    
    Also, would you mind actually running these tests in the default test runner? Just add
something to to the `dev/run-tests` script at the end. I also couldn't seem to actually get
these to run, but maybe I'm not setting up the PYTHONPATH correctly:
    
    ```
    PYTHON_PATH=ec2/third_party/mock-1.0.1.zip/mock-1.0.1 ./ec2/tests.py 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message